Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: orc support fill missing tuple field #17247

Merged
merged 8 commits into from
Jan 16, 2025
Merged

feat: orc support fill missing tuple field #17247

merged 8 commits into from
Jan 16, 2025

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Jan 11, 2025 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. temp orc support fill missing tuple field, including tuple and array(tuple)
  2. speed up orc load by reading each stripe in one IO.
  3. fix cluster key bug bug: error when copy into table with cluster key #17251

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@youngsofun youngsofun added the ci-cloud Build docker image for cloud test label Jan 11, 2025
@youngsofun youngsofun changed the title test orc speed up [do not merge]test orc speed up Jan 11, 2025
@youngsofun youngsofun marked this pull request as draft January 11, 2025 13:51
@youngsofun youngsofun changed the title [do not merge]test orc speed up chore:[do not merge]test orc speed up Jan 11, 2025
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17247-65ef8d6-1736606083

note: this image tag is only available for internal use,
please check the internal doc for more details.

@youngsofun youngsofun added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Jan 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17247-3f8e1bc-1736683784

note: this image tag is only available for internal use,
please check the internal doc for more details.

@youngsofun youngsofun added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17247-853a3f4-1736732036

note: this image tag is only available for internal use,
please check the internal doc for more details.

@youngsofun youngsofun force-pushed the orc2 branch 2 times, most recently from 0ed671e to fbadcf6 Compare January 13, 2025 02:27
@youngsofun youngsofun added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Jan 13, 2025
@youngsofun youngsofun added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Jan 13, 2025
@TCeason TCeason mentioned this pull request Jan 13, 2025
Merged
11 tasks
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17247-11881d5-1736738847

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17247-e5eab6b-1736738985

note: this image tag is only available for internal use,
please check the internal doc for more details.

@zhyass zhyass added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17247-e618b49-1736928075

note: this image tag is only available for internal use,
please check the internal doc for more details.

@youngsofun youngsofun changed the title chore:[do not merge]test orc speed up feat: orc support fill missing tuple field Jan 16, 2025
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jan 16, 2025
@youngsofun youngsofun requested review from b41sh and Xuanwo January 16, 2025 00:47
@youngsofun youngsofun marked this pull request as ready for review January 16, 2025 00:47
@youngsofun youngsofun enabled auto-merge January 16, 2025 01:52
@youngsofun youngsofun added this pull request to the merge queue Jan 16, 2025
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jan 16, 2025
@BohuTANG BohuTANG merged commit ab0d1a8 into databendlabs:main Jan 16, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b41sh b41sh b41sh approved these changes

@Xuanwo Xuanwo Awaiting requested review from Xuanwo

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-chore this PR only has small changes that no need to record, like coding styles. pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@youngsofun @b41sh @BohuTANG @zhyass